SeaLabs Build Above Water #3982
Conversation
|
If the water is too shallow for the subs, then it need to be too shallow for the shipyard too. A shipyard should only be placeable in water deep enough to build every unit in the build list. |
correcl has a water debth of 16, the problem is that is has a waterline of 80, if kept to the latter number sea labs would be unusable on many maps instead. @SethDGamre i can't pinpoint the issue with corasy cortex t2 sea lab |
|
okay, this turns out to be a much weirder problem than imagined. |
| local subDefIDs = {} | ||
| do | ||
| local shipyardsNamesToPads = { | ||
| corsy = 4, |
There was a problem hiding this comment.
put piece name as a customparam imo
There was a problem hiding this comment.
I originally wanted to call the QueryBuildInfo but unfortunately:
1: I couldn't figure out how to get the call to work to get the return param back, if that is even possible.
2: Knowing some of our code malpractices around (me), this could potentially backfire one day.
Will move it to a custom param once i figure out the cases under which the unit goes underground.
There was a problem hiding this comment.
- requires LUS afaik, but factories are a great porting target anyway (their script code is simple and they are rare enough for perf not to be a concern). Calling
QueryBuildInfohere in the gadget would be a bad idea though because the piece can change and then you'd leave the previous one at a different height, but when you have LUS you can just put the logic in each shipyard's script - stuff blowing up is good, how else are yall gonna learn?
| end | ||
|
|
||
| for unitDefID, unitDef in pairs(UnitDefs) do | ||
| if unitDef.waterline and unitDef.minWaterDepth and unitDef.waterline >= 30 then |
There was a problem hiding this comment.
could check movedef, it has an explicit submarine bool
There was a problem hiding this comment.
from what i can find, unitDef.moveDef.subMarine? or would it be moveDef.smClass?
There was a problem hiding this comment.
isSubmarine, also make sure not to index the movedef without a nil check because immobiles/aircraft don't have one
local md = unitDef.moveDef
if md and md.isSubmarine then
Work done
Moves the Sea Lab build point before construction starts so that subs are build floating instead of underwater incase the water is too shalow, as during this state they are not testing debth
*i couldn't figure out how to get the build piece so the list is unfortunately hardcoded for now
Addresses Issue(s)
Setup
Place Sea labs corsy, corasy, armsy, armasy, and build subs with them as wella s non subs
Test steps
Screenshots:
BEFORE:
AFTER: